code in response

src/auth/auth.service.ts

@@ -48,7 +48,6 @@ export class AuthService {
   private readonly otpSalonSignupExpiresInMinutes: number;
   private readonly otpMaxAttempts: number;
   private readonly otpCooldownSeconds: number;
-  private readonly otpDebug: boolean;
   private readonly refreshExpiresIn: string;
 
   constructor(
@@ -86,14 +85,13 @@ export class AuthService {
       this.configService.get<string>('OTP_COOLDOWN_SECONDS') ?? '60',
       10,
     );
-    this.otpDebug = this.configService.get<string>('OTP_DEBUG') === 'true';
     this.refreshExpiresIn =
       this.configService.get<string>('JWT_REFRESH_EXPIRES_IN') ?? '7d';
   }
 
-  async requestOtp(mobile: string): Promise<{ message: string }> {
-    await this.sendOtp(mobile, this.otpExpiresInMinutes);
-    return { message: 'OTP sent' };
+  async requestOtp(mobile: string): Promise<{ message: string; code?: string }> {
+    const code = await this.sendOtp(mobile, this.otpExpiresInMinutes);
+    return this.buildOtpRequestResponse(code);
   }
 
   async checkSalonMobile(
@@ -108,6 +106,7 @@ export class AuthService {
     message: string;
     isRegistered: boolean;
     expiresInSeconds: number;
+    code?: string;
   }> {
     await this.ensureSalonMobileCanProceed(mobile);
     const isRegistered = await this.isSalonOwnerRegistered(mobile);
@@ -115,10 +114,10 @@ export class AuthService {
       ? this.otpExpiresInMinutes
       : this.otpSalonSignupExpiresInMinutes;
 
-    await this.sendOtp(mobile, expiresInMinutes);
+    const code = await this.sendOtp(mobile, expiresInMinutes);
 
     return {
-      message: 'OTP sent',
+      ...this.buildOtpRequestResponse(code),
       isRegistered,
       expiresInSeconds: expiresInMinutes * 60,
     };
@@ -145,7 +144,7 @@ export class AuthService {
   private async sendOtp(
     mobile: string,
     expiresInMinutes: number,
-  ): Promise<void> {
+  ): Promise<string> {
     const recentOtp = await this.otpRepository.findOne({
       where: { mobile, verified: false },
       order: { createdAt: 'DESC' },
@@ -176,16 +175,29 @@ export class AuthService {
 
     const sent = await this.smsService.sendSms(mobile, `کد ورود: ${code}`);
 
-    if (!sent) {
+    if (!sent && !this.shouldExposeOtpInResponse()) {
       throw new BadRequestException('Failed to send OTP');
     }
 
-    if (
-      this.otpDebug &&
-      this.configService.get<string>('NODE_ENV') === 'development'
-    ) {
+    if (this.shouldExposeOtpInResponse()) {
       this.logger.debug(`OTP for ${mobile}: ${code}`);
     }
+
+    return code;
+  }
+
+  private shouldExposeOtpInResponse(): boolean {
+    return this.configService.get<string>('NODE_ENV') !== 'production';
+  }
+
+  private buildOtpRequestResponse(code: string): {
+    message: string;
+    code?: string;
+  } {
+    return {
+      message: 'OTP sent',
+      ...(this.shouldExposeOtpInResponse() ? { code } : {}),
+    };
   }
 
   private async consumeOtp(mobile: string, code: string): Promise<void> {